Merged
Conversation
Collaborator
Author
Member
|
Could you please cover your change with a unit test? |
jcking
force-pushed
the
go-bitset-fix
branch
from
a443fa1 to
4cbb032
Compare
Collaborator
Author
Done. |
jcking
force-pushed
the
go-bitset-fix
branch
from
4cbb032 to
a7318ea
Compare
Collaborator
Author
|
Actually, wait. Need to fix. |
jcking
force-pushed
the
go-bitset-fix
branch
from
a7318ea to
ec7c2f5
Compare
jcking
force-pushed
the
go-bitset-fix
branch
from
ec7c2f5 to
a8b8f87
Compare
Member
|
Maybe also add a grammar sample? |
Collaborator
Author
|
Okay, now its good. The test is more exhaustive and I cleaned them up to be less repetative. |
Member
|
looks like some conflicts after i merged my new test rig. I merged #3421 as a test in my test rig branch but then reversed with a commit. it looks like it left some cruft around. resolved manually, pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally missed the case where
set.datawas small thanb.data, which would lead to a panic. This resolves that.